perf(OpenGL): draw only the polydata primitives that own elements - #3639
Merged
finetjul merged 1 commit intoSep 10, 2026
Merged
Conversation
|
🎉 This PR is included in version 36.14.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
vtkOpenGLPolyDataMappervisits all six primitive helpers on every draw, including helpers with no elements. Thats slow.Results
400 polys-only actors, 300 measured frames per run.
Changes
Record the active helpers in
updateBufferObjectsimmediately afterbuildBufferObjects, including when a subclass overridesbuildBufferObjects.Use that list in
renderPieceDraw, retaining the element-count check for helpersreleased between rebuilds.
Note: A subclass that replaces
updateBufferObjectswithout calling the baseimplementation will not populate the active list.
PR Checklist