perf(Renderer): accumulate actors and volumes without concat - #3638
Merged
Merged
Conversation
finetjul
reviewed
Sep 10, 2026
| // Append array elements individually; append other values as one element. | ||
| function collectFromProps(props, getFromProp) { | ||
| const collected = []; | ||
| props.forEach((prop) => { |
Member
There was a problem hiding this comment.
Sometimes .forEach is slower than a regular for loop. It might not be true each time though (Chrome, Firefox)
Collaborator
Author
There was a problem hiding this comment.
Yes, adopted. Its significantly faster in FireFox.
|
🎉 This PR is included in version 36.14.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
getActors()andgetVolumes()collect each prop's objects using repeatedconcatcalls. Each concat call copies the growing result array.This quadratic work repeats on every
getActorscall, includinggetActors()during picking without an explicit pick list.
Batching geometry into fewer actors is the vtk.js way, but separate
actors are useful when datasets load and unload independently. This change came
out of loading tiled point clouds, where chunks of points are swapped in and out as the view changes.
Results
Recorded headless Chromium medians per collection call, spanning actor and
volume results:
At 2,000 objects, this saves roughly 1 ms per call.
Changes
pushhelper for linear collection, preserving array andnon-array prop answers.
snapshot.
PR Checklist