Add foreign-key constraint to build parentid - #3991
Merged
williamjallen merged 1 commit intoSep 11, 2026
Merged
williamjallen merged 1 commit into
williamjallen merged 1 commit into
Conversation
The build `parentid` column currently uses the magic values `0` and `-1` to represent parent builds. That approach prevented a foreign-key constraint from being added in the past. This PR updates the schema to make the column nullable, add a foreign-key constraint for better referential integrity.
josephsnyder
approved these changes
Sep 11, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build
parentidcolumn currently uses the magic values0and-1to represent parent builds. That approach prevented a foreign-key constraint from being added in the past. This PR updates the schema to make the column nullable, add a foreign-key constraint for better referential integrity.