Add foreign-key constraint to build siteid column - #3990
Merged
josephsnyder merged 1 commit intoSep 11, 2026
Merged
Conversation
The `siteid` column currently doesn't have a foreign-key constraint because the submission process currently creates builds before sites in some cases. This PR gets us closer to the eventual goal of a `NOT NULL` foreign-key constraint by making the column nullable and adding a foreign key constraint. Sometime in the future, this can be upgraded to `NOT NULL` for stricter schema compliance.
josephsnyder
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
siteidcolumn currently doesn't have a foreign-key constraint because the submission process currently creates builds before sites in some cases. This PR gets us closer to the eventual goal of aNOT NULLforeign-key constraint by making the column nullable and adding a foreign key constraint. Sometime in the future, this can be upgraded toNOT NULLfor stricter schema compliance.