Repository navigation
B-rep preview export - #1492
Draft
Irev-Dev wants to merge 11 commits into
Draft
B-rep preview export#1492Irev-Dev wants to merge 11 commits into
Irev-Dev wants to merge 11 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1492 +/- ##
=======================================
Coverage ? 42.00%
=======================================
Files ? 34
Lines ? 1914
Branches ? 0
=======================================
Hits ? 804
Misses ? 1110
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds native_brep as an export format and defines its data contract in format/native_brep.rs. Defining the geometry here is unusual for our export formats, but this one is consumed by both Engine and the browser mesher, so it needs a shared home without making the browser depend on the private format repo. Capture, encoding and meshing stays in the other repos.
format/native_brep.rs This is the main contract between the engine and the browser.