feat: accept extra esbuild compile options - #78
Merged
Merged
Conversation
Let the host merge define/external into the bundle step so Microlink can keep re2 out of Function compiles. Co-authored-by: Cursor <cursoragent@cursor.com>
Current pnpm treats `pnpm install <pkg>` as add and rejects that flag. Co-authored-by: Cursor <cursoragent@cursor.com>
Coverage Report for CI Build 34506393320Warning No base build found for commit Coverage: 95.232%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
esbuildobject from the factory or per call into the compile step.external/definewithout baking package-specific rules into this repo.re2out of Function bundles (vmOpts.esbuild).Test plan
test/compile/build.jsassertsdefineis applied@browserless/function/ the API and compilerequire('xml-urls')Made with Cursor