Repository navigation
Nar id label mapping - #33
Open
bhillkeyfactor wants to merge 3 commits into
Open
bhillkeyfactor wants to merge 3 commits into
bhillkeyfactor wants to merge 3 commits into
Conversation
Pin System.Drawing.Common 5.0.3 in the plugin (pulled in by Keyfactor.Logging and Keyfactor.PKI) and System.Formats.Asn1, System.Net.Http and System.Text.RegularExpressions in the test project to clear known advisories.
Add an optional nar_id enrollment parameter. When set, its value is passed through unchanged as the nar_id label on the certificate created in GCP CAS. Empty or missing values apply no label. Add unit tests for the client, plugin, request builder, parsers, config and FlowLogger using a fake Google client (line coverage 18.6% -> 98.2%).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.