Repository navigation
Advertise legacy product names in GetProductIds for CA auto-resolution - #33
Closed
bhillkeyfactor wants to merge 1 commit into
Closed
bhillkeyfactor wants to merge 1 commit into
bhillkeyfactor wants to merge 1 commit into
Conversation
Command uses GetProductIds to auto-resolve a CA for a template when none is explicitly selected, matching the template's configured product ID against each CA's advertised list. Existing Certificate Templates created before the 1.2.0 product rename are still configured with the old names (e.g. "CSC TrustedSecure EV Certificate"), which GetProductIds stopped advertising once it was switched to the canonical list only - auto-resolution then fails with "No CA was found to issue the specified template" for any legacy-named template, even though explicit CA selection still works (that path goes through the more lenient ValidateProductInfo, which already accepts legacy names).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetProductIds()only returned the 10 canonical (1.2.0+) product names, not the pre-1.2.0 legacy names still accepted byValidateProductInfo/GetCertificateType.GetProductIds()to auto-resolve a CA for a template when no CA is explicitly selected. A Certificate Template still configured with a legacy name (created before the 1.2.0 rename) has no match in that list, so auto-resolution fails with "No CA was found to issue the specified template..." Explicit CA selection still works since it goes through the more lenientValidateProductInfo.GetProductIds()now returns the union of canonical names and legacy aliases.Test plan
GetProductIds_ReturnsFullList->GetProductIds_ReturnsCanonicalAndLegacyNames, asserting both canonical and legacy names are present (17 total).dotnet test- 206/206 passing.