Conversation
Signed-off-by: minleejae <mmj9808@gmail.com>
Signed-off-by: minleejae <mmj9808@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL accepts
CREATE COLLATION c FROM "C"and parameter-based definitions, but these statements were unsupported. Collation DDL is needed when parsing schema scripts that use non-default text comparison rules.Add CREATE/ALTER COLLATION nodes and reuse the existing structured option representation and expression printer. Copy-source and parameter forms are mutually exclusive; ALTER supports REFRESH VERSION, RENAME, OWNER and SET SCHEMA. Preserve bare flags such as deterministic, which PostgreSQL's grammar and server accept.
Tests cover copy/options forms, providers, mutations, expression traversal, malformed input, and statement boundaries. Ten additional definitions/alterations were executed on PostgreSQL 18.6, including libc/builtin providers and bare deterministic, with matching collation catalog state after both renderers. ICU syntax is covered by parser tests; the local runtime checks do not claim ICU availability.
Syntax references: CREATE COLLATION, ALTER COLLATION.
Validation: focused tests, JavaCC ambiguity checks, Checkstyle and Spotless on this independent branch. The combined implementation also passes the full Gradle check and Maven verify; the 1,304-input prior regression corpus has no previously successful input regressions.