Reuse PostgreSQL constraint attributes in ALTER CONSTRAINT - #2717
Merged
manticore-projects merged 1 commit intoSep 27, 2026
Conversation
Signed-off-by: minleejae <mmj9808@gmail.com>
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL ALTER CONSTRAINT accepts deferrability, initial timing, and enforcement attributes, including combinations that the existing ALTER parser rejected. CREATE TABLE and ADD CONSTRAINT already had a structured representation for these attributes.
Reuse ConstraintAttributes in a dedicated ALTER CONSTRAINT node, retaining the existing constraint-name and enforcement accessors. Share attribute parsing with CREATE/ADD constraints and reject empty ALTER actions, duplicate attributes, and NOT VALID in this context.
Tests compare CREATE, ADD and ALTER representations, exercise attribute permutations and AST mutations, and retain the existing ENFORCED behavior. Relevant accepted cases were executed on PostgreSQL 18.6, with original and both rendered forms producing matching constraint catalog state. Constraint-type/catalog restrictions remain the database's responsibility.
Syntax reference: ALTER TABLE.
Validation: focused tests, JavaCC ambiguity checks, Checkstyle and Spotless on this independent branch. The combined implementation also passes the full Gradle check and Maven verify; the 1,304-input prior regression corpus has no previously successful input regressions.