feat: share additional MySQL table options across CREATE and ALTER - #2713
Merged
manticore-projects merged 3 commits intoSep 25, 2026
Merged
manticore-projects merged 3 commits into
manticore-projects merged 3 commits into
Conversation
Signed-off-by: minleejae <mmj9808@gmail.com>
Contributor
|
Please resolve conflicts. |
Signed-off-by: minleejae <mmj9808@gmail.com>
Signed-off-by: minleejae <mmj9808@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MySQL CREATE TABLE failed on INSERT_METHOD=NO, while ALTER TABLE preserved several supported options as raw text. This shares typed TableOption parsing across CREATE and ALTER for SECONDARY_ENGINE, AUTOEXTEND_SIZE, INSERT_METHOD, PACK_KEYS, DELAY_KEY_WRITE, CHECKSUM, CONNECTION and COMPRESSION.
Each option keeps its own value syntax: secondary engines accept identifiers, quoted names or NULL; sizes accept unsigned integers and K/M/G suffixes; insertion modes and PACK_KEYS use their allowed keywords; string and numeric options stay distinct. The existing scalar-option dispatch and legacy accessors are reused.
Validation: full Gradle check including grammar ambiguity, unit tests and static analysis. Tests cover both equals forms, CREATE/ALTER AST equivalence and mutation, comma boundaries, round trips and invalid values. Original/toString/deparser execution and catalog comparison passed for 38 combinations on MySQL 9.7.2 and 26.7.0. Six original statements were rejected due to engine/filesystem support and were excluded from parser correctness claims; engine-specific runtime effects are not asserted for ignored options. AUTOEXTEND_SIZE in numeric, K and M forms also passed six additional executions across both versions.
Sources: MySQL CREATE TABLE, ALTER TABLE and the corresponding server grammar.