feat: share policy options across PostgreSQL policy DDL - #2711
Merged
manticore-projects merged 3 commits intoSep 25, 2026
Merged
manticore-projects merged 3 commits into
manticore-projects merged 3 commits into
Conversation
Signed-off-by: minleejae <mmj9808@gmail.com>
Signed-off-by: minleejae <mmj9808@gmail.com>
Contributor
|
Please resolve conflicts. |
Signed-off-by: minleejae <mmj9808@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL ALTER POLICY and DROP POLICY were not parsed, although CREATE POLICY already exposed roles and predicates. This prevented tools from processing a complete row-security policy migration.
Add typed ALTER/DROP policy statements and share PolicyOptions between CREATE and ALTER. Preserve the existing CreatePolicy API while routing its printers through the shared role/predicate representation. Policy names remain separate from target tables, and expression/table visitors traverse USING and WITH CHECK subqueries.
Validation: full Gradle check and grammar ambiguity gate; mutation, traversal, malformed-input and following-statement tests. All 14 audited CREATE/ALTER/DROP cases preserve selected policy catalog results on PostgreSQL 18.6 for original, toString and deparser SQL.