fix: replace partition key representations consistently - #2710
Merged
manticore-projects merged 1 commit intoSep 25, 2026
Merged
Conversation
Signed-off-by: minleejae <mmj9808@gmail.com>
Contributor
|
Good cleanup, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing a parsed partition key from a single expression to an expression list or column list could leave the old expression active. For example, converting HASH(id) to KEY(other) rendered KEY(id), silently changing the intended result.
Make the partition key representations mutually exclusive through a shared state reset. Existing setters remain available, and setting an inactive representation to null preserves the active key. Regression tests cover PostgreSQL multiple/attributed keys and MySQL HASH/KEY transitions through both renderers.
Validation: full Gradle check and grammar ambiguity gate. Database-backed mutation checks compare the requested partition definition with PostgreSQL 18.6 and MySQL 9.7.2 / 26.7.0 catalogs.