feat: reuse NOT NULL constraints for PostgreSQL column definitions - #2696
Merged
manticore-projects merged 1 commit intoSep 24, 2026
Merged
Conversation
Signed-off-by: minleejae <mmj9808@gmail.com>
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL 18 supports named column NOT NULL constraints and
NOT NULL NO INHERIT. JSqlParser already models the table form, but the column form is rejected or loses the connection to that structured constraint model.Reuse
NotNullConstraintfor named/non-inheritable column constraints, with an explicit flag for the implicit target column. CREATE TABLE and ALTER TABLE ADD COLUMN share the grammar, including the existing table-level NO INHERIT parser. Plain unnamed NOT NULL retains its existingColumnOption.Kind.NULLABILITYrepresentation. Traversal does not invent a second column expression for an implicit target.Validation:
checkwith Java 17, including grammar ambiguity and static analysis.toString(), and deparser SQL and constraint catalogs. Each confirms that the parent rejects NULL while a child does not inherit the NO INHERIT constraint. PostgreSQL and the parser both reject NOT NULL ENFORCED.Use
Dialect.POSTGRESQL, consistently with the existing PostgreSQL constraint paths. Reference: PostgreSQL 18 CREATE TABLE.