feat: share PostgreSQL foreign key enforcement attributes - #2695
Merged
manticore-projects merged 1 commit intoSep 24, 2026
Merged
manticore-projects merged 1 commit into
manticore-projects merged 1 commit into
Conversation
Signed-off-by: minleejae <mmj9808@gmail.com>
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL 18 accepts
ENFORCEDandNOT ENFORCEDon foreign keys, but JSqlParser currently rejects these clauses in table constraints and columnREFERENCESdefinitions. This prevents consumers from inspecting or rewriting DDL that deliberately disables enforcement.This change stores the optional enforcement flag in
ConstraintAttributesand shares attribute parsing across CREATE/ALTER table constraints and column references. CHECK constraints delegate their existing enforcement accessors to the same state, avoiding duplicate storage and rendering. Column references stop before a followingNOT NULL;NOT VALIDremains a table-constraint form.Validation:
checkwith Java 17, including grammar ambiguity and static analysis.toString(), andStatementDeParserforms. Compared constraint catalogs and enforcement behavior, including deferred and NOT VALID constraints. Two invalid column-reference cases are rejected by both PostgreSQL and the parser.Reference: PostgreSQL 18 CREATE TABLE.