feat: share MySQL scalar table options across CREATE and ALTER - #2694
Merged
manticore-projects merged 2 commits intoSep 24, 2026
Merged
manticore-projects merged 2 commits into
manticore-projects merged 2 commits into
Conversation
Signed-off-by: minleejae <mmj9808@gmail.com>
Signed-off-by: minleejae <mmj9808@gmail.com>
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Model MySQL ENCRYPTION, PASSWORD, DATA DIRECTORY, and INDEX DIRECTORY as typed table options. Extract their value grammar together with AUTO_INCREMENT for reuse across CREATE and ALTER.
Existing ALTER string getters remain live projections of the structured option, and legacy string setters still work. Tests cover quoted paths, optional equals signs, large unsigned values, comma boundaries, AST edits, and legacy setters.
Validation:
checkpassed (Java 17), including grammar ambiguity, unit tests, coverage, formatting, Checkstyle, PMD, and SpotBugs.Syntax reference: official documentation.
Additional version-boundary validation: the original, toString, and deparser SQL was executed on isolated MySQL 9.7.2 and 26.7.0 servers, including the focused behavioral cases. Added regression cases for VECTOR with omitted dimensions and dimensions 0, 1, 2048, and 16383 before ENCRYPTION. Reviewed the MySQL 9.7 and MySQL 26.7 grammar. Runtime version numbers above identify the tested binaries; this does not claim support for every statement in those DBMS versions.