fix: reuse structured constraints for MySQL inline CHECK - #2688
Merged
manticore-projects merged 2 commits intoSep 24, 2026
Merged
Conversation
Signed-off-by: minleejae <mmj9808@gmail.com>
Signed-off-by: minleejae <mmj9808@gmail.com>
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MySQL column CHECK clauses with
ENFORCEDorNOT ENFORCEDare not handled consistently with table constraints. Route column checks through the existingCheckConstraintSpecproduction andCheckConstraintAST.CREATE TABLE and ALTER ADD/MODIFY/CHANGE already share column option parsing; all now retain the constraint name, expression, and enforcement flag, including custom expression deparsing.
Validation:
checkpassed (Java 17), including grammar ambiguity, unit tests, coverage, formatting, Checkstyle, PMD, and SpotBugs.Syntax reference: official documentation.
Additional version-boundary validation: the original, toString, and deparser SQL was executed on isolated MySQL 9.7.2 and 26.7.0 servers, including the focused behavioral cases. Also tested PostgreSQL 18.6 inline CHECK NOT ENFORCED with and without NO INHERIT, and added regressions. Reviewed the MySQL 9.7 and MySQL 26.7 grammar. Runtime version numbers above identify the tested binaries; this does not claim support for every statement in those DBMS versions.