fix: preserve PostgreSQL identity sequence names - #2687
Merged
manticore-projects merged 1 commit intoSep 24, 2026
Merged
Conversation
Signed-off-by: minleejae <mmj9808@gmail.com>
Contributor
|
thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL identity
SEQUENCE NAMEoptions currently lose their qualified sequence name during parsing/rendering. Keep the name as a structuredSequence.Parametervalue so callers can inspect or rename it without editing opaque tokens.The shared identity production is used by CREATE TABLE and ALTER TABLE ADD IDENTITY, while numeric options continue to use the existing sequence parameter parser. Standalone sequence and ALTER SET option syntax remain separate.
Validation:
checkpassed (Java 17), including grammar ambiguity, unit tests, coverage, formatting, Checkstyle, PMD, and SpotBugs.Syntax reference: official documentation.
Additional version-boundary validation: the original, toString, and deparser SQL was executed on PostgreSQL 18.6, including the focused behavioral cases. Reviewed the PostgreSQL 18 grammar. Runtime version numbers above identify the tested binaries; this does not claim support for every statement in those DBMS versions.