Upgrade axios@1.16.0 - #577
vincent-tock wants to merge 1 commit into
Conversation
|
Hey team, any plans or blockers on approving this upgrade? We ask because our security team has also flagged this and atm we are evaluating options. |
|
Apologies for tagging @joaodordio, we really would love if you could help us with this one 🙏 Perhaps share if this could be merged or if there is a blocker? |
|
Thanks for this @vincent-tock, and sorry for the slow turnaround. The report was accurate and useful. Also thanks @sameersw for the nudge. I've opened #585 which does the upgrade, and I'm closing this one in favour of it. Two reasons we couldn't merge this as-is: The lockfile points at a private registry. Both new entries resolve from That's your company Artifactory mirror leaking in from a local 1.16.0 has since gone stale. Ten advisories now affect it, including the high severity #585 carries you as co-author. It's green locally across typecheck, tests, both builds and lint, and it'll go out in the next release. |
* chore: upgrade axios to 1.18.0 Resolves the ten open advisories affecting axios 1.14.0, including the high severity proxy-through-interceptor-config-cloning issue (GHSA-gcfj-64vw-6mp9). All of them are patched in 1.18.0. Stops at 1.18.0 rather than the latest 1.20.0 because 1.20.0 adds a fourth generic to AxiosResponse that types config.params and config.data, which breaks compilation of authorization.test.ts. That cleanup belongs in its own change. Supersedes #577 from Vincent Taing, whose lockfile resolved packages from a private Artifactory mirror. Co-authored-by: Vincent Taing <vtaing@tockhq.com> * chore: keep sample app axios pins in lockstep with the SDK The react-example and example apps install their own axios copy. When only the root pin moved, tsc saw two structurally different AxiosResponse types across the two node_modules trees and the react-example build failed, taking the e2e job with it. --------- Co-authored-by: Vincent Taing <vtaing@tockhq.com>
Description
We're trying to adopt iterable-web-sdk at my company, Squarespace, however this will not pass our Vulnerability Scan step because this CVE.
Test Steps
Ran the test