Howl send vc00 - #90
Open
jackbdoughty wants to merge 12 commits into
Open
jackbdoughty wants to merge 12 commits into
jackbdoughty wants to merge 12 commits into
Conversation
added 8 commits
September 15, 2026 14:37
… not send vc00 yet.
Member
|
I think there might be a misunderstanding here - enabled vetoes are the ones that a user has said they care about, probabilities are the ones actually applied to events. So from a Saluki perspective it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows howl to send a vc00 containing veto info and also correctly passes veto info to event messages.
Removes functionality for passing just one probability and having all vetoes go off this.
To test I did different variations of
saluki howl sarada:9092 JackDTestwith different arguments e.g. names, enabled, probabilities. Look for results onsaluki consume sarada:9092/JackDTest_vetoConfig. Have a play and see if chosen arguments affect the result in an expected way.Also check that vc00 is sent after the run start as mentioned in ticket.