Ticket8830 muon beamcorr

[LowriJenkins]

Description of work

Implemented Muon Beam Correction IOC

Ticket

Link to Ticket

Acceptance criteria

• An IOC exists that applies appropriate corrections to beam positions for each of the south side instruments based on the known strength of the other instruments main magnets.
• Information on this IOC is exposed to users
• Existing documentation for what is planned is updated to be documentation for this IOC.
• Testing is scheduled with the relevant muon beam-lines out of cycle to ensure it functions as expected

Unit tests

Tests are present in the IOC-Test-Framework pullrequest.

Code Review

• A copy of the manual has been placed on the shared drive
• Pertitent information has been stored in the wiki
• Does the IOC conform to IBEX standards?
  • PV naming.
  • Disable records
  • Record simulation
  • Finishing touches
• If an OPI has been modified, does it conform to the style guidelines?
• Do the IOC and support module conform to the new build guidelines
• Have the changes been recorded appropriately in a PR for release notes?
• Is the device's flow control setting correct? For most devices flow control should be OFF.

Functional Tests

• IOC responds correctly in:
  • Devsim mode
  • Recsim mode
  • Real device, if available
• Supplementary IOCs (..._0n where n>1) run correctly
• Log files do not report undefined macros (serach for macLib: macro to find instances of macLib: macro [macro name] is undefined...

Final steps

• Update the IOC submodule in the main EPICS repo. See Git workflow page for details.
• Reviewer has merged the associated PR for the release notes

[LowriJenkins]

As well as running the tests, it's worth running through with the IOC not in simulation mode testing it actually talking to appropriate IOCS (e.g. danfysiks or kepcos).