You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
we may make deviceemulator pip-installable, so this makes that change easier. I'm not going to start fixing all the ruff stuff as i'd rather keep the file same for now.
Should we leave non lewis emulators in the DeviceEmulators module? One of the rational for moving lewis emulators to lewis itself was for non-epics use, wouldn't the same situation apply to non-lewis emulators too?
I was going to make deviceemulator into a lewis-devices pip-installable package (ISISComputingGroup/EPICS-DeviceEmulator#189), so didn't want to include stuff that wasn't related. i can move out to a separate module, but thought it might be better off here? maybe we need an other_emulators repo?
I'm just coming from the "consistent approach" angle - if we feel having lewis emulators outside of the ioc test framework/support modules is better for sharing, isn't the same true for non-lewis emulators we create? So maybe a other_emulators module is needed if DeviceEmulators is being repurposed as lewis only. Just a though - maybe we could
git mirror DeviceEmulators to LewisDevices
remove other emulators from LewisDevices
remove lewis from DeviceEmulators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I haven't copied history here but it's a vendor emulator and some exe files...
linked to ISISComputingGroup/EPICS-DeviceEmulator#187 - please merge alongside this.
we may make deviceemulator pip-installable, so this makes that change easier. I'm not going to start fixing all the ruff stuff as i'd rather keep the file same for now.