Conversation
pyrooka
force-pushed
the
nb/disallow-relative-path
branch
from
September 24, 2026 14:26
3ecc1cd to
f49d6ba
Compare
Path parameters with value "." or ".." are not encoded by the standard encoding functions (encodeURIComponent, requests.utils.quote, OkHttp addPathSegment, url.PathEscape) because dots are RFC 3986 unreserved characters. The downstream HTTP client then performs standard dot-segment normalisation, silently retargeting the request to a different resource than the caller intended. Add a validation guard that rejects any path parameter value that is exactly "." or ".." with a clear error message, in the same location and following the same pattern as the existing empty-value guards. Pre-encoding is not a viable workaround as it produces double-encoded values (%252E) which change the meaning of the parameter. Fixes: CWE-23 (Relative Path Traversal) / CWE-116 CVSS 3.1: AV:N/AC:L/PR:L/UI:N/S:U/C:H/I:H/A:H = 8.8 Signed-off-by: Norbert Biczo <pyrooka@users.noreply.github.com>
pyrooka
force-pushed
the
nb/disallow-relative-path
branch
from
September 24, 2026 14:30
f49d6ba to
3cd17e6
Compare
pyrooka
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.