feat: add optional accountId support to CP4D authenticator - #371
Open
jacek-midura wants to merge 1 commit into
Open
jacek-midura wants to merge 1 commit into
jacek-midura wants to merge 1 commit into
Conversation
Add an optional accountId field to both CloudPakForDataAuthenticator and Cp4dTokenManager. When provided, the value is included as account_id in the POST /v1/authorize request body. When reading from external configuration (env vars / credentials file), the property CP4D_ACCOUNT_ID is camelCased to cp4dAccountId by readExternalSources and remapped to accountId before constructing the authenticator. Signed-off-by: Jacek Midura <jacek.midura@pl.ibm.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: https://github.ibm.com/arf/planning-sdk-squad/issues/4470
Add an optional accountId field to both CloudPakForDataAuthenticator and Cp4dTokenManager. When provided, the value is included as account_id in the POST /v1/authorize request body.
When reading from external configuration (env vars / credentials file), the property CP4D_ACCOUNT_ID is camelCased to cp4dAccountId by readExternalSources and remapped to accountId before constructing the authenticator.
Checklist
npm testpasses (tip:npm run lint-fixcan correct most style issues)