better permission check for outdated index deletion - #27282
Open
todvora wants to merge 7 commits into
Open
Conversation
todvora
marked this pull request as ready for review
September 4, 2026 11:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The POST /api/system/indexer/indices/outdated/bulk_delete endpoint (added in 7.2) only enforced the indices:delete permission deep inside its per-index loop, after it had already enumerated all outdated indices on the cluster via @RequiresAuthentication alone. This let any authenticated user with no index permissions trigger the cluster-wide enumeration, and let the differing per-index failure messages ("not found" vs "not authorized") act as an index-membership oracle. This PR adds an upfront check in bulkDeleteOutdated that rejects the request with 403 Forbidden before any work is done, unless the caller holds the general indices:delete permission or a per-index grant for at least one of the submitted entity_ids — preserving the existing per-managed-index permission model (see deleteSingleOutdated) while closing the gap.
Motivation and Context
Fixes https://github.com/Graylog2/graylog-plugin-enterprise/issues/15476
How Has This Been Tested?
Added unit tests
Types of changes
Checklist: