Add magnitude bars to the math expression parser - #4565
Merged
Merged
Conversation
…n each part Magnitude bars `|x|` give the magnitude on every rung, with `|` opening where an operand is expected and closing where an operator is, and `||` reading as Or unless two magnitudes are open, while `abs()` stays the absolute value of each part. The `real()`, `imag()`, and `arg()` functions are removed in favor of the matrix literals and `angle()` the specification defines for those readings.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 6 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|x| is the magnitude (Euclidean norm), abs(x) is now the component-wise absolute value:
|-3 -4i|is5abs(-3 - 4i)is3 + 4i.This also removes
real(),imag(), andarg()since the spec describes upcoming replacements for those.Partly closes #2026