Allow the math parser's expression results to become complex instead of NaN - #4564
Merged
Merged
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
…ever producing NaN Every value is a quaternion in principle, so narrower storage is never observable: a result whose imaginary part is zero is the real number, `-0` is `0`, and a real input whose answer leaves the real line climbs into the complex plane (`sqrt(-4)` is `2i`, `ln(-1)` is `iπ`, `asin(2)` its complex value) instead of producing NaN. No operation returns NaN at all: an indeterminate form like `0/0` or `∞ - ∞` is an evaluation error, as is a NaN arriving through a host binding at its point of use.
Keavon
force-pushed
the
math-parser-complex-climbing
branch
from
September 21, 2026 18:45
5e0036e to
10b9996
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partly closes #2026