Repository navigation
Conversation
…that has several numbers (fixes GrapheneOS#542)
RankoR
force-pushed
the
fix-542-enter-multi-number-contact
branch
from
November 11, 2026 18:54
3b35f0d to
dad07d5
Compare
|
Tested on Pixel 10a. If you search a contact whose number starts with an area code that matches or partially matches a country code, the "send to" dialog appears. This prevents the enter key from opening a conversation with your contact. For example, entering all 10 digits of a number that has an area code of 337, that area code overlaps with frances country code of 33. So (337) 123-4567 would show "send to +1 (337) 123-4567" and also show that contact below it. Pressing both options enters the same conversation with the same contact. |
…aved with a country code by reading it only in the primary country and preferring exact matches, so Enter never picks the same digits in another country
Member
Author
|
Fixed in 31f7835 |
|
Tested on Pixel 10a. Invalid numbers with matching contacts now present only the contact when typed exactly. LGTM |
RankoR
marked this pull request as ready for review
November 16, 2026 19:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #542