Repository navigation
Sync internal changes - #78
Merged
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
PiperOrigin-RevId: 718003674
PiperOrigin-RevId: 728571468
PiperOrigin-RevId: 733776326
PiperOrigin-RevId: 758723370
PiperOrigin-RevId: 802593042
PiperOrigin-RevId: 822155822
PiperOrigin-RevId: 833441604
PiperOrigin-RevId: 836252796
…angling pointer. PiperOrigin-RevId: 836343382
PiperOrigin-RevId: 840489807
PiperOrigin-RevId: 841778812
PiperOrigin-RevId: 869261811
PiperOrigin-RevId: 869299341
PiperOrigin-RevId: 869329884
…`GarbageInstrumentationFunction` hooks in heap_sampler. PiperOrigin-RevId: 871450042
…CONSTRUCTORS. PiperOrigin-RevId: 872413860
…EventSampledObjectAlloc callbacks. PiperOrigin-RevId: 885713184
`StringId(absl::string_view)`. After we migrate internal callers, we will delete the `const char*` overload. PiperOrigin-RevId: 886273178
…::profiles::Builder::StringId(). PiperOrigin-RevId: 888226795
Redaction works by translating all mappings and their corresponding location addresses to a more compact address space that starts at 0x200000. Creates a temporary copy of the const input Profile on an arena and modify the copy's mapping and location addresses before serializing it. PiperOrigin-RevId: 889321380
PiperOrigin-RevId: 890103712
PiperOrigin-RevId: 894147246
…ace address range. PiperOrigin-RevId: 896740561
`c_str()` is already guaranteed to be non-null. `data()` is also usually non-null, but if it is null, then the string_view is empty, so the `NullSafeStringView` wrapper is still a no-op. PiperOrigin-RevId: 901472540
PiperOrigin-RevId: 915117713
PiperOrigin-RevId: 929345325
PiperOrigin-RevId: 933517241
PiperOrigin-RevId: 934459293
PiperOrigin-RevId: 944608109
…t the active instruction rather than a return address. PiperOrigin-RevId: 945259231
PiperOrigin-RevId: 954308413
PiperOrigin-RevId: 954616173
PiperOrigin-RevId: 955343807
PiperOrigin-RevId: 955614519
PiperOrigin-RevId: 956942659
PiperOrigin-RevId: 979973927
PiperOrigin-RevId: 990479317
In third_party/javaprofiler/clock.h, TimeAdd checked
`t.tv_nsec > kNanosPerSecond` instead of `t.tv_nsec >= kNanosPerSecond`.
When `t1.tv_nsec + t2.tv_nsec == kNanosPerSecond` (1,000,000,000), TimeAdd
returned an unnormalized timespec with `tv_nsec = 1,000,000,000`.
When passed to Clock::SleepUntil or Clock::SleepFor, clock_nanosleep
immediately returns EINVAL (22). Because SleepUntil and SleepFor looped
while `clock_nanosleep(...) > 0` instead of `== EINTR`, the profiler
worker thread spun indefinitely at 100% CPU.
Normalize `t.tv_nsec >= kNanosPerSecond` in TimeAdd, retry clock_nanosleep
only on EINTR in SleepUntil and SleepFor, and as extra safety initialize
`profile_period` via NanosToTimeSpec(period_nanos_) instead of
`{0, period_nanos_}` in WallProfiler::Collect so `profile_period` is
always normalized when EffectivePeriodNanos scales `period_nanos_` to
>= 1s.
PiperOrigin-RevId: 995225455
PiperOrigin-RevId: 997737625
PiperOrigin-RevId: 1006696556
PiperOrigin-RevId: 1006940604
PiperOrigin-RevId: 1007011121
PiperOrigin-RevId: 1007837647
PiperOrigin-RevId: 1007875749
aabmass
force-pushed
the
copybara_staging
branch
from
October 29, 2026 02:34
f18a11d to
f5b1be6
Compare
psx95
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.