Skip to content

Stop using the reserved word packed as a shader name - #4

Merged
FueledByRedBull merged 1 commit into
mainfrom
fix/nvidia-reserved-word
Nov 10, 2026
Merged

FueledByRedBull merged 1 commit into
mainfrom
fix/nvidia-reserved-word

Conversation

@FueledByRedBull

Copy link
Copy Markdown
Owner

v0.7.2 got past the image-unit check on an NVIDIA GPU and then stopped at "Shader compilation failed: embedded sand_pack.comp". NVIDIA's compiler rejects packed as a variable name because GLSL reserves the word. AMD's compiler and glslang 16.6.0 both accept it, which is why nothing caught it here.

sand_pack.comp and water_pack.comp now use packedCount. gpu-compile also scans every shader file and fails on any word GLSL reserves for future use; a probe shader with uint packed fails it as expected. No other shader uses one.

Tested on an RX 7800 XT: ctest 103/103, POWDER_REPLAY=all passes with every signature identical to v0.7.2. Still not run on NVIDIA hardware.

NVIDIA's compiler rejects packed, a GLSL reserved word, so sand_pack.comp failed to build there. AMD's compiler and glslang accept it. gpu-compile now fails any shader that uses a reserved word.
@FueledByRedBull
FueledByRedBull merged commit aedee3d into main Nov 10, 2026
2 checks passed
@FueledByRedBull
FueledByRedBull deleted the fix/nvidia-reserved-word branch November 10, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant