Repository navigation
Stop using the reserved word packed as a shader name - #4
Merged
Merged
Conversation
NVIDIA's compiler rejects packed, a GLSL reserved word, so sand_pack.comp failed to build there. AMD's compiler and glslang accept it. gpu-compile now fails any shader that uses a reserved word.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v0.7.2 got past the image-unit check on an NVIDIA GPU and then stopped at "Shader compilation failed: embedded sand_pack.comp". NVIDIA's compiler rejects
packedas a variable name because GLSL reserves the word. AMD's compiler and glslang 16.6.0 both accept it, which is why nothing caught it here.sand_pack.compandwater_pack.compnow usepackedCount.gpu-compilealso scans every shader file and fails on any word GLSL reserves for future use; a probe shader withuint packedfails it as expected. No other shader uses one.Tested on an RX 7800 XT: ctest 103/103, POWDER_REPLAY=all passes with every signature identical to v0.7.2. Still not run on NVIDIA hardware.