fix(release): one GitHub release step, not two - #46
Merged
Conversation
The v2.0.1 release failed: HTTP 422: Validation Failed Release.tag_name already exists release.yml carried the step twice. The first named the release for the version with the v stripped, which is how the 2.0.0 and 2.0.1 releases already on this repository were created, so creating 2.0.1 a second time was refused. The duplicate arrived when the v-prefix change was applied on top of a file that already had the step. The two are merged into one: the changelog lookup and the install line from the first, the existence guard from the second, and the release named for the tag rather than the stripped version, so a vX.Y.Z tag produces a vX.Y.Z release. The bare 2.0.0 and 2.0.1 releases are left alone. They point at the tags that were actually published, and renaming them would break any link anyone holds.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
v2.0.1release failed:release.ymlcarried the step twice. The first named the release for the version with thevstripped — which is how the2.0.0and2.0.1releases already on this repository were created — so creating2.0.1a second time was refused. The duplicate arrived when #45 applied the v-prefix change on top of a file that already had the step.Nothing was damaged:
flat-api 2.0.1on PyPI is untouched, and the publish step was correctly skipped by the new guard (it saw the version already on PyPI). Only the release step failed.The two are merged into one, keeping the better half of each:
pip installline from the firstvX.Y.Ztag produces avX.Y.ZreleaseThe bare
2.0.0and2.0.1releases are left alone: they point at the tags actually published, and renaming them would break any link anyone holds.