fix(rp): reacquire same-name CDC after BOOTSEL deploy - #1405
Conversation
|
Warning Review limit reachedNext included review available in 55 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: FastLED/fbuild/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
cb0ae05 to
de07334
Compare
|
Rebased onto current Not done: the hardware HIL run. The coordinated FastLED PR (FastLED/FastLED#4062) was closed without merging, so that run never happened. The change is covered by the focused RED→GREEN regression test, but the Windows RP2350 same-name COM reacquisition itself is unverified on hardware. 🤖 Generated with Claude Code |
Summary
Why
A phantom COM record such as
COM18was counted as already present before an RP2350 UF2 flash. When the board returned healthy onCOM18, post-flash discovery filtered it out solely because its name had not changed, so deploy returned no application port and AutoResearch could not continue.Validation
bash test -p fbuild-deploy— 288 passed, 13 ignoredsoldr cargo fmt --all -- --checksoldr cargo clippy -p fbuild-deploy --all-targets -- -D warningsbash testCloses #1404
Coordinated with FastLED/FastLED#4062.