Skip to content

fix(rp): reacquire same-name CDC after BOOTSEL deploy - #1405

Merged
zackees merged 1 commit into
mainfrom
feat/rp-selector-fallback
Sep 18, 2026
Merged

zackees merged 1 commit into
mainfrom
feat/rp-selector-fallback

Conversation

@zackees

@zackees zackees commented Aug 26, 2026

Copy link
Copy Markdown
Member

Summary

  • exclude known-unhealthy RP CDC devnodes from the pre-flash name snapshot
  • allow a stale Windows COM selector to use an unambiguous mounted BOOTSEL volume
  • reacquire a healthy runtime CDC endpoint even when Windows reuses the same COM name

Why

A phantom COM record such as COM18 was counted as already present before an RP2350 UF2 flash. When the board returned healthy on COM18, post-flash discovery filtered it out solely because its name had not changed, so deploy returned no application port and AutoResearch could not continue.

Validation

  • focused regression test: RED before helper, GREEN after implementation
  • bash test -p fbuild-deploy — 288 passed, 13 ignored
  • soldr cargo fmt --all -- --check
  • soldr cargo clippy -p fbuild-deploy --all-targets -- -D warnings
  • full bash test
  • pre-push review clean
  • hardware HIL pending completion of the coordinated FastLED run

Closes #1404
Coordinated with FastLED/FastLED#4062.

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 55 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: FastLED/fbuild/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 802cefcc-24bb-4c11-a7c2-ac745cae6c66

📥 Commits

Reviewing files that changed from the base of the PR and between 3713843 and de07334.

📒 Files selected for processing (2)
  • crates/fbuild-deploy/src/rp2040.rs
  • crates/fbuild-deploy/src/rp2040_target.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees
zackees force-pushed the feat/rp-selector-fallback branch from cb0ae05 to de07334 Compare September 18, 2026 21:31
@zackees
zackees marked this pull request as ready for review September 18, 2026 21:31
@zackees

zackees commented Sep 18, 2026

Copy link
Copy Markdown
Member Author

Rebased onto current main (2.5.24) and marked ready. After the rebase: bash test -p fbuild-deploy 288 passed / 13 ignored, clippy -D warnings clean, fmt --check clean.

Not done: the hardware HIL run. The coordinated FastLED PR (FastLED/FastLED#4062) was closed without merging, so that run never happened. The change is covered by the focused RED→GREEN regression test, but the Windows RP2350 same-name COM reacquisition itself is unverified on hardware.

🤖 Generated with Claude Code

@zackees
zackees merged commit dc7a714 into main Sep 18, 2026
19 checks passed
@zackees
zackees deleted the feat/rp-selector-fallback branch September 18, 2026 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

fix(rp): reacquire same-name CDC after BOOTSEL deploy

1 participant