Fix Illegal invocation in moderation emails - #233
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
No issues found across 4 files
Auto-approved: Fixes Cloudflare Workers fetch binding for both moderation email providers and the factory path. The focused regression test verifies the corrected behavior without changing rollout, contracts, or operational policy.
Re-trigger cubic
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
api | 18a42a8 | Commit Preview URL Branch Preview URL |
Sep 17 2026, 02:07 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both email senders defaulted to a bare
globalThis.fetchreference, which throwsIllegal invocationon Cloudflare Workers (fetch requires itsthisreceiver). This broke all moderation notifications regardless of provider, surfacing asnotified: false(e.g. developer-approved). Adds a bounddefaultFetchwrapper inemail/types.tsand uses it as the default inMxrouteSenderandResendSender.Adds a regression test that stubs
globalThis.fetchwith Workers-likethisenforcement and covers both senders plus thecreateEmailSender(env)factory path used bynotify.ts.