Fix moderation email rendering and remove reply wording - #232
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
api | 94c55cf | Commit Preview URL Branch Preview URL |
Sep 17 2026, 11:11 AM |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
|
Both cubic comments addressed in c5f49ff (I don't have permission to resolve the threads — please resolve if you're happy):
Checks: typecheck, lint, Prettier clean; 86/86 tests pass across |
There was a problem hiding this comment.
All reported issues were addressed across 2 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
|
New P2 addressed in 94c55cf (again, please resolve the thread — no permission on my token):
Also rebased onto your |
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Auto-approved: Fixes moderation email rendering (ASCII-safe subjects, entity-encoded HTML, explicit dashboard links) and stops inviting replies or sending Reply-To when unset, with focused tests and docs updated.
Re-trigger cubic
1 participant
Follow-up to #226.
Reply wording removed. There is no monitored inbox, but
extension-delistedandclaim-rejectedinvited recipients to "reply to this email" — replies went tonoreply@fossbilling.orgwith noReply-Toset. Delisted keeps its dashboard link; claim-rejected now links the dashboard instead of inviting a reply. TheEXTENSIONS_V2_EMAIL_REPLY_TOdoc no longer usesnoreply@…as its example, and tests no longer enshrine reply-to-noreply (prod sends noReply-To; the forwarding path stays covered by a dedicated unit test).Unicode rendering fixed. Live mail showed mojibake around names and moderator notes (
“Smoke…”→“…,—→—): MXroute's SMTP API hands our strings to PHPMailer with itsiso-8859-1default and offers no charset parameter, so raw UTF-8 bytes were mislabeled. Templates now emit ASCII-only subjects (diacritics stripped, punctuation mapped, remainder?) and entity-encoded HTML bodies (—), which render identically via Resend too. Bodies are complete<html><body>documents (cleared theHTML_MIME_NO_HTML_TAGSpamAssassin flag; score went from -5.9 to -6.5) and dashboard URLs are explicit<a>anchors rather than bare text. Names pasted with their own quotes no longer double up against the label's wrapping quotes.