lightningd: initialize error pointer in connect_activate_subd and handle_splice_abort - #9449
Open
Andezion wants to merge 1 commit into
Open
lightningd: initialize error pointer in connect_activate_subd and handle_splice_abort#9449Andezion wants to merge 1 commit into
Andezion wants to merge 1 commit into
Conversation
…dle_splice_abort Fixes ElementsProject#9442 Changelog-None
Andezion
force-pushed
the
fix/uninitialized-error-ptr-9442
branch
from
August 27, 2026 09:58
ab7cad7 to
a6e57cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9442
Same uninitialized-pointer pattern as #8849 (fixed in 090f4b0 for handle_peer_spoke) also exists in:
connect_activate_subd()in lightningd/peer_control.chandle_splice_abort()in lightningd/channel_control.cIn both,
const u8 *error- is declared uninitialized and only conditionally set viasockpair(..., &error)before falling through to a path that dereferences it.sockpair()currently always sets the output pointer on failure, so this isn't exploitable today, but the declaration should still default toNULLdefensively in case that invariant ever breaksFix: initialize both declarations to NULL.
Testing: compiled
lightningd/channel_control.oandlightningd/peer_control.ocleanly - no behavior change on existing pathsImportant
26.09 FREEZE August 5th: Non-bugfix PRs not ready by this date will wait for 26.12.
RC1 is scheduled on August 17th
The final release is scheduled for September 7th.
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:
tools/lightning-downgrade