Skip to content

PunctureTracker: Fix ordering and validity issues - #66

Open
lucass-carneiro wants to merge 3 commits into
mainfrom
bug/PunctureTracker_ordering
Open

lucass-carneiro wants to merge 3 commits into
mainfrom
bug/PunctureTracker_ordering

Conversation

@lucass-carneiro

Copy link
Copy Markdown
Contributor

This PR addresses the following two problems in PunctureTracker:

  1. PunctureTracker/src/puncture.cxx — updatePreviousTime opened with DECLARE_CCTK_ARGUMENTS, which declares a pointer to every variable the thorn can see and trips CCTK_HasAccess for each one not in the routine's READS/WRITES. This results in 39 spurious "Possibly illegal access" warnings per iteration in a CCTK_DEBUGbuild. It needscctk_timeand nothing else, so it now takes it fromcGH`.
  2. PunctureTracker/schedule.ccl: Both PunctureTracker_Setup and PunctureTracker_Track are read-modify-write routines on partially-written array groups, so WRITES alone makes CarpetX poison and abort at iteration 0 under poison_undefined_values = yes. Declaring the READS is what makes the ordering driver-enforced. The addition of AFTER BoxInBox_Init also enforces that the correct scheduling.

@lucass-carneiro

Copy link
Copy Markdown
Contributor Author

Please note that the original PR did not change the CI scripts, but because CI was broken anyway, I'm fixing it here.

My CI fix is very simple: I copied all of my homework from the CarpetX CI optionlists and these seem to be working fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant