PunctureTracker: Fix ordering and validity issues - #66
Open
lucass-carneiro wants to merge 3 commits into
Open
lucass-carneiro wants to merge 3 commits into
lucass-carneiro wants to merge 3 commits into
Conversation
…ry argument. declare its reads and order its setup after BoxInBox_Init
Contributor
Author
|
Please note that the original PR did not change the CI scripts, but because CI was broken anyway, I'm fixing it here. My CI fix is very simple: I copied all of my homework from the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the following two problems in
PunctureTracker:PunctureTracker/src/puncture.cxx — updatePreviousTimeopened withDECLARE_CCTK_ARGUMENTS, which declares a pointer to every variable the thorn can see and tripsCCTK_HasAccess for each one not in the routine'sREADS/WRITES. This results in 39 spurious "Possibly illegal access" warnings per iteration in aCCTK_DEBUGbuild. It needscctk_timeand nothing else, so it now takes it fromcGH`.PunctureTracker/schedule.ccl: BothPunctureTracker_SetupandPunctureTracker_Trackare read-modify-write routines on partially-written array groups, soWRITESalone makesCarpetXpoison and abort at iteration 0 underpoison_undefined_values = yes. Declaring the READS is what makes the ordering driver-enforced. The addition ofAFTER BoxInBox_Initalso enforces that the correct scheduling.