Skip to content

AbstractHttpTransport#logRequest always constructs message despite of logging level #248

Description

@robotmrv

https://github.com/Ecwid/consul-api/blob/232550b44e122f42446876835946baf2de333f53/src/main/java/com/ecwid/consul/transport/AbstractHttpTransport.java#L133C15-L163C25

Since it logs only at finest level it is reasonable to add short cut check for log level before message construction

if (!loger.isLoggable(Level.FINEST)) {
    return;
}

to avoid unnecessary memory allocations.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions