add pre-configure hook for Visit to deal with filtered zlib dependency - #305
Merged
Merged
Conversation
boegel
requested changes
Sep 16, 2026
boegel
changed the title
boegel
approved these changes
Sep 20, 2026
boegel
left a comment
boegel
left a comment
Contributor
There was a problem hiding this comment.
lgtm
tested manually, works like a charm, thanks @pavelToman!
Contributor
|
bot: build repo:eessi.io-2023.06-software instance:eessi-bot-jsc for:arch=aarch64/nvidia/grace |
|
New job on instance
|
|
New job on instance
|
|
New job on instance
|
Contributor
|
just want to make sure we don't deploy an outdated copy of our hooks, since I synced with bot: build repo:eessi.io-2023.06-software instance:eessi-bot-jsc for:arch=aarch64/nvidia/grace |
|
New job on instance
|
|
New job on instance
|
|
New job on instance
|
Contributor
|
staging PR merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VisIt explicitly configures zlib through
-DVISIT_ZLIB_DIR.In EESSI, zlib is filtered as an EasyBuild dependency because it is provided by the compatibility layer. As a result, the VisIt configure step can fail to locate zlib:
Add a VisIt-specific pre-configure hook that, when
zlibis a filtered dependency, ensures-DVISIT_ZLIB_DIRpoints to${EESSI_EPREFIX}/usr.If
-DVISIT_ZLIB_DIRis already present inconfigopts, its value is replaced. If it is not present, the option is added.Required for EESSI/software-layer#1525