Skip to content

make sure that necessary quotes are retained for --fusemount "..." option in output produced by eessi_container.sh - #304

Merged
bedroge merged 2 commits into
EESSI:mainfrom
boegel:eessi_container_fusemount_quotes
Sep 11, 2026
Merged

bedroge merged 2 commits into
EESSI:mainfrom
boegel:eessi_container_fusemount_quotes

Conversation

@boegel

@boegel boegel commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Basic tests (+ CI we have for this script) shows it still works as expected, and now shows double quotes for --fusemount option in output:

$ ./eessi_container.sh
Using /tmp/eessi.IlIzx9UzvZ as tmp directory (to resume session add '--resume /tmp/eessi.IlIzx9UzvZ').
Pulling container image from docker://ghcr.io/eessi/build-node:debian12 to /tmp/eessi.IlIzx9UzvZ/ghcr.io_eessi_build_node_debian12.sif
...
Mounting 'software.eessi.io' 'read-only' without fuse-overlayfs.
Launching container with command (next line):
singularity -q shell  --fusemount "container:cvmfs2 software.eessi.io /cvmfs/software.eessi.io" /tmp/eessi.IlIzx9UzvZ/ghcr.io_eessi_build_node_debian12.sif
CernVM-FS: pre-mounted on file descriptor 3
Apptainer> CernVM-FS: loading Fuse module... done

Apptainer> ls /cvmfs/software.eessi.io/versions/
2023.06  2025.06  2026.06
$ ./eessi_container.sh --access rw
Using /tmp/eessi.7zXeg0exUt as tmp directory (to resume session add '--resume /tmp/eessi.7zXeg0exUt').
Pulling container image from docker://ghcr.io/eessi/build-node:debian12 to /tmp/eessi.7zXeg0exUt/ghcr.io_eessi_build_node_debian12.sif
...
Launching container with command (next line):
singularity -q shell  --fusemount "container:cvmfs2 software.eessi.io /cvmfs_ro/software.eessi.io" --fusemount "container:unionfs -o cow /tmp/software.eessi.io/overlay-upper=RW:/cvmfs_ro/software.eessi.io=RO /cvmfs/software.eessi.io" /tmp/eessi.7zXeg0exUt/ghcr.io_eessi_build_node_debian12.sif

…tion in output produced by eessi_container.sh
Comment thread eessi_container.sh
BIND_PATHS="${BIND_PATHS},/cvmfs/cvmfs-config.cern.ch"
else
EESSI_FUSE_MOUNTS+=("--fusemount" "container:cvmfs2 cvmfs-config.cern.ch /cvmfs/cvmfs-config.cern.ch")
EESSI_FUSE_MOUNTS+=("--fusemount" '"container:cvmfs2 cvmfs-config.cern.ch /cvmfs/cvmfs-config.cern.ch"')

@Micket Micket Sep 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
EESSI_FUSE_MOUNTS+=("--fusemount" '"container:cvmfs2 cvmfs-config.cern.ch /cvmfs/cvmfs-config.cern.ch"')
EESSI_FUSE_MOUNTS+=("--fusemount" "\"container:cvmfs2 cvmfs-config.cern.ch /cvmfs/cvmfs-config.cern.ch\"")

For consistency?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meh, I figured I could avoid escaping the double quotes here, since there's no ${EESSI*} environment variable involved here, I would keep it as is.

@bedroge
bedroge merged commit e549af2 into EESSI:main Sep 11, 2026
93 checks passed
@boegel
boegel deleted the eessi_container_fusemount_quotes branch September 11, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants