Improve flexibility of ingest-tarball.sh by adding command-line options - #282
Merged
Merged
Conversation
Collaborator
Author
|
So the tests passed with the old syntax, 770eb56 changes them to make use of the new syntax. |
bedroge
marked this pull request as ready for review
September 14, 2026 13:09
Collaborator
Author
|
Openen an issue with a TODO: #284. I think this PR is ready now. |
Member
|
Looks like I can't actually merge this one 😅 |
Member
|
Now I can 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first step in making the ingestion process for site builds easier. The new
-b / --basediroptions allows you to override the basedir used for the ingestion.Note that the old syntax
ingest-tarball.sh REPO TARBALLstill works, but prints a warning. The new syntax would beingest-tarball.sh -r REPO TARBALL.I haven't changed the tests yet, just to make sure that they still pass with the old syntax.
Also, there is code to override the basedir for dev.eessi.io. We could leave that for now, but ultimately the automated ingestion calling this script should just pass the correct basedir.