Repository navigation
fix(presets): correct eFootball/PES preset buttons and stop the picker snapping it back to FIFA - #2
Merged
Conversation
…flow fix(input): stop startup heap corruption from an undersized Raw Input device-name buffer
… to FIFA in the picker and pressed the wrong controller buttons - layouts now match each game's real Xbox defaults (EA FC 'Classic': A pass, B shoot, X cross, Y through; Konami 'Standard', the PES 2017 scheme: A pass, X shoot, B cross, Y through, dash on RB)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Two related bugs made the Football (eFootball / PES) preset unusable:
"Football (FIFA / EA FC)". The Mapping picker identified the active preset
by comparing only the physical key list, and the two football presets
deliberately share the same keys (same hand positions, different game
conventions), so any football layout always matched FIFA first.
were mapped to controller buttons Konami doesn't use for them, so e.g.
pressing "shoot" crossed the ball in-game.
What changed
button table (
list_preset_bindingsreplaceslist_preset_keys), soevery preset is identified individually.
corrected:
B shoot · X cross/lob · Y through ball · RT sprint.
2017 through eFootball ship with): A low pass · X shoot · B lofted
pass/cross · Y through ball · RB dash · RT specials. Xbox labels are
positional (PS ▢/○/△ sit on Xbox X/B/Y).
eFootball's "Alternate" layout equals the EA FC preset (and vice versa).
Verification
key→target table; football presets follow each game's documented Xbox
defaults; two players running the same preset on two keyboards stay
independent).
cargo test --no-runcompiles the full binary.bun run build), ESLint clean.Also includes the standard release chores (README, CHANGELOG, version bump
to 0.3.8) - note merging this will trigger the auto-release workflow and
publish v0.3.8.