Skip to content

fix(presets): correct eFootball/PES preset buttons and stop the picker snapping it back to FIFA - #2

Merged
E4crypt3d merged 3 commits into
E4crypt3d:mainfrom
Salmankbdev:fix/pes-preset-picker
Sep 6, 2026
Merged

E4crypt3d merged 3 commits into
E4crypt3d:mainfrom
Salmankbdev:fix/pes-preset-picker

Conversation

@Salmankbdev

Copy link
Copy Markdown
Contributor

What and why

Two related bugs made the Football (eFootball / PES) preset unusable:

  1. You couldn't select it - choosing PES appeared to snap straight back to
    "Football (FIFA / EA FC)". The Mapping picker identified the active preset
    by comparing only the physical key list, and the two football presets
    deliberately share the same keys (same hand positions, different game
    conventions), so any football layout always matched FIFA first.
  2. The buttons were wrong for the game - pass/shoot/cross/through ball
    were mapped to controller buttons Konami doesn't use for them, so e.g.
    pressing "shoot" crossed the ball in-game.

What changed

  • The picker now fingerprints each preset by its full key → controller
    button
    table (list_preset_bindings replaces list_preset_keys), so
    every preset is identified individually.
  • Football layouts were researched against the games' own control charts and
    corrected:
    • EA FC / FIFA documents EA's in-game Classic scheme: A pass ·
      B shoot · X cross/lob · Y through ball · RT sprint.
    • eFootball / PES follows Konami's Standard scheme (the layout PES
      2017 through eFootball ship with): A low pass · X shoot · B lofted
      pass/cross · Y through ball · RB dash · RT specials. Xbox labels are
      positional (PS ▢/○/△ sit on Xbox X/B/Y).
  • Preset descriptions now state which in-game scheme each matches and that
    eFootball's "Alternate" layout equals the EA FC preset (and vice versa).

Verification

  • 32/32 Rust lib tests pass (3 new: every preset has a distinct
    key→target table; football presets follow each game's documented Xbox
    defaults; two players running the same preset on two keyboards stay
    independent). cargo test --no-run compiles the full binary.
  • Frontend typechecks and builds clean (bun run build), ESLint clean.

Also includes the standard release chores (README, CHANGELOG, version bump
to 0.3.8) - note merging this will trigger the auto-release workflow and
publish v0.3.8.

…flow

fix(input): stop startup heap corruption from an undersized Raw Input device-name buffer
… to FIFA in the picker and pressed the wrong controller buttons - layouts now match each game's real Xbox defaults (EA FC 'Classic': A pass, B shoot, X cross, Y through; Konami 'Standard', the PES 2017 scheme: A pass, X shoot, B cross, Y through, dash on RB)
@E4crypt3d
E4crypt3d merged commit e7018f2 into E4crypt3d:main Sep 6, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants