Repository navigation
Conversation
Contributor
Author
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





What and why
Closes #88. This follows #92, which you closed because the chat stays the conversation. It moves the same idea into the bot's panel, as you suggested there, and leaves the chat exactly as it is on
dev: no chat file is touched and there is no switch.The bot panel's Computer tab gains a short list, "Commands and browsing", under the bot's browser or screen:
Server side, kept small:
tool.mson a finished tool message, for the finished line's time.server/harness/live-steps.ts).browserPreviewCapture). Frames flow only once that turn's own browser call has claimed the browser, and a group turn still posts no screenshot message when it ends.server/index.tsstays at 16,896 lines.No new dependency. New strings are in
en.jsononly.How it was checked
pnpm exec vitest run src/components/bot-panel src/components/room-panel src/components/live-cards src/state/command-tails.test.ts src/state/browser-snapshots.test.ts src/state/turn-status.test.ts src/components/type-scale.test.ts server/harness/live-steps.test.ts server/direct-screen-settlement-api.test.ts server/screen-frame-source.test.ts scripts/testing/group-browser-frames.e2e.test.ts: 35 files, 292 tests pass.src/components/bot-panel/PanelSteps.test.tsis new and covers the list: latest turn only, newest first, the running entry open, no picture beside the live browser, one member's steps in a group.scripts/testing/group-browser-frames.e2e.test.tsis new: a real isolated server, the fake Claude engine and the pinned agent-browser on a local page. It passes here and fails on untoucheddev, where no frame reaches a group's thread.scripts/control-dusk.ts ui launch, never live data), in a 1:1 chat with the panel open: a command streaming output and folding with the fake Codex engine; a browser run on a local page with the fake Claude engine; a new turn replacing the previous turn's entries.pnpm lintandpnpm i18n:checkpass.Not seen or not covered:
tool.mshas no server test of its own.Checks that already fail on
devAll on macOS, on an untouched checkout of
devat 6c14850 as well as on this branch. None is in a file this PR touches.pnpm typecheck: the same five errors, inapps/dashboard/server/clouds/ai-stash.test.ts,server/cloud-mac.e2e.test.ts,server/mac-control/cloud.test.ts,server/mac-control/seal.test.tsandserver/group-local-vm.e2e.test.ts.Source guards (the step CI stops at):
src/locales/sentence-case.test.tsfails onchat.event.peerReplied("replied"), andsrc/locales/server-lines.test.tsfails on a line inshared/computer-unreachable.ts.server/index.test.ts: five cases fail the same way with and without this change: "buzzes when a turn dies before it can start", "creates team computers only with consent…", "reports a failed routine once, not twice", "shares one team computer across direct and room turns…", and "shows a card continuation that cannot start as the root's failed turn…".I did not run the whole two-hour suite on this base; I ran the suites above.
pnpm typecheck,pnpm lintandpnpm testpass (lint passes; typecheck and tests fail only wheredevalready does, see above)New behaviour has a test (except
tool.ms, noted above)No secrets, personal data or local paths in the diff or screenshots