Skip to content

perf: use generator expression for MRO filtering in WebDriver #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dor-bl wants to merge 1 commit into
base: master
Choose a base branch
from
Open

perf: use generator expression for MRO filtering in WebDriver #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion appium/webdriver/webdriver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,7 @@ def _add_commands(self) -> None:
# call the overridden command binders from all mixin classes except for
# appium.webdriver.webdriver.WebDriver and its sub-classes
# https://github.com/appium/python-client/issues/342
for mixin_class in filter(lambda x: not issubclass(x, WebDriver), self.__class__.__mro__):
for mixin_class in (x for x in self.__class__.__mro__ if not issubclass(x, WebDriver)):
if hasattr(mixin_class, self._add_commands.__name__):
get_atter = getattr(mixin_class, self._add_commands.__name__, None)
if get_atter:
Expand Down
Loading