Skip to content

🧪 test: add unit tests for orientation setter - #13

Open
Dor-bl wants to merge 1 commit into
masterfrom
test-orientation-7851551434230814572
Open

🧪 test: add unit tests for orientation setter#13
Dor-bl wants to merge 1 commit into
masterfrom
test-orientation-7851551434230814572

Conversation

@Dor-bl

@Dor-bl Dor-bl commented Aug 10, 2026

Copy link
Copy Markdown
Owner

🎯 What: The orientation setter lacked test coverage in the Appium Python Client, and also silently skipped invalid orientation values instead of raising an error.
📊 Coverage: The new tests in test/unit/webdriver/webdriver_test.py cover:

  • Getting the orientation
  • Setting valid orientations ('LANDSCAPE', 'PORTRAIT')
  • Setting invalid orientations (e.g. 'INVALID'), checking that a WebDriverException is correctly raised
    Result: Test coverage for the orientation property is complete, and the underlying implementation is more robust as it throws a proper error for incorrect orientations.

PR created automatically by Jules for task 7851551434230814572 started by @Dor-bl

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@Dor-bl
Dor-bl force-pushed the test-orientation-7851551434230814572 branch from 948ed82 to 5aa05c9 Compare September 5, 2026 06:59
@Dor-bl
Dor-bl force-pushed the test-orientation-7851551434230814572 branch from 5aa05c9 to dbbdb5d Compare September 5, 2026 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant