feat(ui): show serving binary version (#1820) - #2016
Conversation
Expose the compiled server version through the existing UI config endpoint and render it beside the product name. Keep older or unavailable config responses compatible by hiding the label, with focused frontend and native endpoint coverage. Fixes DeusData#1820 Signed-off-by: Rares Popa <2606875+rarepops@users.noreply.github.com>
0e3c9a3 to
e0785b3
Compare
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
|
Approved on merit. Small, well-scoped, and it follows the existing conventions rather than inventing any. The #ifndef CBM_VERSION
#define CBM_VERSION "dev"
#endifis verbatim the pattern already in Extending Handling the three display states separately — visible, invalid, unavailable — is what makes this safe on the frontend. Hiding the label when the endpoint fails or returns no string means a version that is missing never renders as On exposure: the version is already public via One noteYour validation shows CI is still early (3 of 11 reported). I will merge on green — our Actions queue has been heavily backlogged today, though it is finally draining. |
What does this PR do?
Fixes #1820.
/api/ui-configresponsevX.Y.Zlabel beside the Codebase Memory nameThis uses the existing same-origin config endpoint and adds no external request, dependency, MCP method, or configuration key.
Validation
cd graph-ui && npm test(46 passed)cd graph-ui && npm run build./build/c/test-runner httpdunder GCC ASan/UBSan (64 passed, 1 platform skip)make -f Makefile.cbm lint-format CLANG_FORMAT=clang-format-20git diff --checkChecklist
git commit -s)make -f Makefile.cbm test) (full native suite not run; focused UI and HTTP suites passed)make -f Makefile.cbm lint-ci) (full lint not run; pinned formatting gate passed)Screenshot