Add skill CLI install mode - #1215
Conversation
|
Thanks for the submission. This head is blocked as submitted for concrete security and scope reasons. The installed skill includes a mutable |
|
Thanks for this, and sorry for the slow first response. Queued for review. Two mechanical blockers before I read it: the branch is CONFLICTING against Flagging one thing early so it does not surprise you at review time: an install-mode addition touches the CLI public surface, so beyond correctness there is a scope question about whether it belongs. That is a maintainer call rather than a reflection on the code. |
|
Reviewed alongside the other agent-install PRs in the queue. This one is not superseded — but it needs a maintainer decision and a rework, and there is one thing in the shipped skill content I would ask you to change regardless. First, the thing I would change whatever else happens. The new CLI-mode skill text embeds this: It is our own repository and you gated it behind "ask the user before installing", which shows the right instinct. But it is still a remote-code-execution recipe sitting inside an instruction file that an agent reads and follows, and it is pinned to The rest of the instruction content is fine — assertive but product-consistent, and I noted the protective rules you included ("ask before Why it needs a decision rather than a merge:
Also architectural: cli mode short-circuits On the idle-timeout half: it is a clean additive API and the parse is properly bounds-checked, but I have put both questions to the maintainer. Please hold off reworking until there is an answer — between the framework rebuild and the daemon rework, this is a substantial rebase and it would be unfair to have you do it against a design that might change. One incidental thank-you: your drive-by adding |
|
The product answer I have owed you since 24 July: yes to the concept — a CLI-invocation skill mode is wanted, as an install flag — but it will be realised inside the client-surface architecture being built in #1188, not as this branch's implementation. You were asked to hold off reworking until there was an answer; you did exactly that, including not pushing a single commit after the block. That discipline is noted and appreciated — and it is why this close comes with the concept accepted rather than the PR churned. What "inside #1188's architecture" means concretely: the marketplace/client-surface direction was decided today (see the comment there). The skill-content selection in its slice 1 is being designed with a per-client variant seam, and the CLI-instruction variant becomes an The mechanical blockers from 24/31 July stand for any future incarnation, so they are on the record in one place: the I am parking this PR closed in favour of the #1188 track. When the CLI variant ships you will be credited — the concept, the ask-first protective gates in your skill text, and the install-flag shape all trace to this contribution. Thank you for it, and for how you handled the wait. |
Summary
This PR adds an install mode for the Codebase Memory skill that can use the CLI instead of installing the MCP config.
The idea is simple: sometimes we do not want the LLM session to always load the MCP tool definitions. Those tool definitions use context space even when the user does not need code graph tools. With this skill mode, the LLM keeps only a small skill instruction. When it needs the graph, it runs
codebase-memory-mcp cli <tool> '<json>'from the shell.So the tool is still available when needed, but it does not need to stay as MCP tools in the active context all the time.
What changed
--skill-mode=cli|mcpfor install.--skill-mode=mcpkeeps current default behavior.--skill-mode=cliinstalls the Claude Code skill and skips MCP configs/hooks.check_index_coverage.Notes
This does not include local memory / personal memory functionality. That belongs to another branch.
Validation
scripts/build.shscripts/test.sh tests/test_cli.c tests/test_mcp.c--skill-mode=cli