Repository navigation
Make semantic fingerprints optional on deployments - #2729
Merged
Merged
Conversation
Adds a semantic_fingerprints query parameter (default true) to POST /deployments and POST /deployments/impact. When false, the orchestrator skips building fingerprints and the results report null.
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
shangyian
marked this pull request as ready for review
November 15, 2026 06:02
Contributor
 [Medium impact] The PR appears safe to merge. SummaryMakes semantic fingerprints optional on deployment and impact requests.
No actionable issues found. Tests were inspected but not run. Reviews (1) · Last reviewed commit: "Make semantic fingerprints optional on d..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
semantic_fingerprintsquery parameter (defaults totrue) toPOST /deploymentsandPOST /deployments/impact. When set tofalse, the orchestrator skips building fingerprints.Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan