Repository navigation
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
Pushdown only refused a joined dimension's attribute when its name matched a foreign-key column. A same-named non-key column on the fact (or on another dimension) received the filter, and a fact column filter could land on a dimension CTE with the same column name. Bind a dimension attribute only to its own CTE, and a fact column to a dimension only through the link's join key or when the fact reads from that dimension.
shangyian
force-pushed
the
dj/same-name-column-filter
branch
from
November 13, 2026 23:44
73b1115 to
29279c9
Compare
shangyian
marked this pull request as ready for review
November 13, 2026 23:44
Contributor
 [Medium impact] The PR appears safe to merge; the reported rename issue is fixed, and no new blocking issue was found. SummaryThis PR keeps filters from binding to unrelated columns with the same name.
Reviews (3) · Last reviewed commit: "Trace a pushed filter's column through e..." · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan