chore: split near oom file - #405
Merged
Merged
Conversation
Overall package sizeSelf size: 2.6 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | pprof-format | 2.3.1 | 504.33 kB | 504.33 kB | | source-map | 0.8.0 | 185.66 kB | 185.66 kB | | node-gyp-build | 4.8.4 | 13.86 kB | 13.86 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
IlyasShabi
marked this pull request as ready for review
September 1, 2026 12:32
IlyasShabi
requested review from
nsavoire,
r1viollet and
szegedi
as code owners
September 1, 2026 12:32
nsavoire
approved these changes
Sep 1, 2026
szegedi
approved these changes
Sep 1, 2026
szegedi
left a comment
szegedi
left a comment
There was a problem hiding this comment.
Thank you, it is indeed much clearer this way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Moves the near-OOM code out of
heap.ccinto a newnear-oom.{hh,cc}files. No behaviour change and the moved code is identical, comments included.Motivation:
heap.cchad grown into two unrelated concerns sharing a file. Splitting it makes each file readable on its own and gives the near-OOM code a place to grow without pushing the profiler API further apart.