Make Java convention the composition root - #12333
Open
bric3 wants to merge 1 commit into
Open
Conversation
bric3
marked this pull request as ready for review
August 28, 2026 13:59
amarziali
approved these changes
Aug 28, 2026
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
More details
The Java convention keeps the deleted aggregator's plugin and script order. No build script still refers to the deleted file.
🤖 Datadog Autotest · Commit ebc24bc · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Move dependency locking and the remaining
java_deps.gradleandjava_no_deps.gradlecomposition intodd-trace-java.conventions.java.Delete the now-unreferenced
gradle/java.gradlecompatibility aggregator and retain the Spotless regression guard with guidance toward the Java convention.Motivation
After #12331 migrates the remaining direct consumers, the Java convention can become the composition root and own the incremental extraction of its remaining legacy internals.
See #12258.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue