Skip to content

Make Java convention the composition root - #12333

Open
bric3 wants to merge 1 commit into
refactor/apply-java-convention-remaining-projectsfrom
bdu/java-convention-composition-root
Open

Make Java convention the composition root#12333
bric3 wants to merge 1 commit into
refactor/apply-java-convention-remaining-projectsfrom
bdu/java-convention-composition-root

Conversation

@bric3

@bric3 bric3 commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

Move dependency locking and the remaining java_deps.gradle and java_no_deps.gradle composition into dd-trace-java.conventions.java.

Delete the now-unreferenced gradle/java.gradle compatibility aggregator and retain the Spotless regression guard with guidance toward the Java convention.

Motivation

After #12331 migrates the remaining direct consumers, the Java convention can become the composition root and own the incremental extraction of its remaining legacy internals.

See #12258.

Contributor Checklist

@bric3 bric3 added tag: no release notes Changes to exclude from release notes type: refactoring comp: tooling Build & Tooling tag: ai generated Largely based on code generated by an AI or LLM labels Aug 28, 2026
@bric3
bric3 marked this pull request as ready for review August 28, 2026 13:59
@bric3
bric3 requested a review from a team as a code owner August 28, 2026 13:59
@bric3
bric3 requested review from amarziali and removed request for a team August 28, 2026 13:59
@datadog-prod-us1-6

This comment has been minimized.

@datadog-prod-us1-6 datadog-prod-us1-6 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The Java convention keeps the deleted aggregator's plugin and script order. No build script still refers to the deleted file.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit ebc24bc · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@dd-octo-sts

dd-octo-sts Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.03 s 13.96 s [-0.4%; +1.4%] (no difference)
startup:insecure-bank:tracing:Agent 12.95 s 12.99 s [-1.0%; +0.3%] (no difference)
startup:petclinic:appsec:Agent 16.47 s 16.75 s [-6.2%; +2.8%] (no difference)
startup:petclinic:iast:Agent 16.83 s 16.89 s [-1.0%; +0.3%] (no difference)
startup:petclinic:profiling:Agent 16.06 s 16.77 s [-8.6%; +0.1%] (no difference)
startup:petclinic:sca:Agent 16.74 s 16.53 s [+0.3%; +2.2%] (maybe worse)
startup:petclinic:tracing:Agent 16.06 s 16.33 s [-2.7%; -0.6%] (maybe better)

Commit: ebc24bc0 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: tooling Build & Tooling tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants